Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMFMorph: Sort out assign fiasco #191

Open
weefuzzy opened this issue Jul 25, 2022 · 0 comments
Open

NMFMorph: Sort out assign fiasco #191

weefuzzy opened this issue Jul 25, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@weefuzzy
Copy link
Member

The whole business with having to cycle autoassign in NMFMorph is silly and bad, so it's time to fix it. There's actually two aspects to this:

  1. Most urgent: we keep and fix the current behaviour so that autoassign actually does what it says. We can do this, I think, by change tracking the pointers on the input buffers (we don't need to deref them, just compare stored with current). This should tell the client if a buffer has changed in some drastic way, and can be used to set an 'needsAssign' flag to pass through. If the pointer hasn't changed, but the buffer content has, then a toggle would still be needed.
  2. Get that whole business out of the audio thread. That's a much more complex proposition, but really the assignment calculation needs to happen in response to a message and then there needs to be some sort of copy-update to pass the new assignment to the audio thread. That entails a sort of hybrid object we don't yet have a model for.
@weefuzzy weefuzzy self-assigned this Jul 25, 2022
@weefuzzy weefuzzy added the enhancement New feature or request label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant