Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperCollider action Description not rendering properly #99

Open
tedmoore opened this issue Mar 22, 2022 · 6 comments
Open

SuperCollider action Description not rendering properly #99

tedmoore opened this issue Mar 22, 2022 · 6 comments
Assignees

Comments

@tedmoore
Copy link
Member

I noticed in BufStats.rst that this is written:

Screenshot 2022-03-22 at 14 39 59

Yet, what appears in the rendered SC help file inside of SuperCollider is:

Screenshot 2022-03-22 at 14 39 48

This language for the action function is getting pulled from the template. It would be preferable to be able to specify different action functions for each object.

@jamesb93
Copy link
Member

I'm not sure I get it. Can you explain the problem to me in another way?

@tedmoore
Copy link
Member Author

There is text in the RST that is not ending up in the .schelp file. This is because the text for the action function seems to not be pulled from the RST but is instead hard-coded into the template file. Rather than hard-coding in the description for this action function it would be good to have the template get the text from the RST.

@jamesb93
Copy link
Member

Oh yeah, sorry the difference is subtle when you are not a careful reader like me 🤦. Thanks for spelling it out :)

@weefuzzy
Copy link
Member

  • The text for action is currently rendered unconditionally in flucoma/doc/templates/schelp_buffer-proc.schelp for buffer processors' process[Blocking]
  • OTOH, it is specified separately in the reStructured for each message of the data objects

IMO, neither of these is very good. We'd evidently like to be able to override the default text for the buffer processors (as here). Meanwhile, I'm not wild about having the actions for messages appear just like any other argument in the reStructuredText because that means every other host presumably has to make a special-case for them and ignore. What would be preferable would be for both cases to have a default that gets rendered but can be overridden, but also that doesn't pollute the general documentation with a host-specific implementation detail. I don't know what that mechanism is yet, but will think on it.

@tedmoore
Copy link
Member Author

can be overridden

Yes. This would be wonderful.

The .. only_in:: sc seems to work quite well. Is this useful?

@weefuzzy
Copy link
Member

Not sure that it would do the job here, as we're needing to make individual fields in a field_list conditional rather than normal body elements: what would show up in ..only would be its own field_list tree that would have, somehow, to be merged with one above, if present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants