Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Review external suffixes to add architecture as well as platform #42

Open
weefuzzy opened this issue Apr 26, 2022 · 1 comment
Open

CMake: Review external suffixes to add architecture as well as platform #42

weefuzzy opened this issue Apr 26, 2022 · 1 comment
Assignees
@weefuzzy
Labels
enhancement New feature or request
Milestone
Version 1.0

Comments

@weefuzzy
Copy link
Member

See #40 (comment)

Apparently best practice is to have something like .pd_linux.l_ia64 to help disambiguate different architectures. Need to find out is this applies to all OSes, and what the magic strings are.
@weefuzzy weefuzzy added the enhancement New feature or request label Apr 26, 2022
@weefuzzy weefuzzy self-assigned this Apr 26, 2022
@tremblap tremblap added this to the beta8 milestone May 10, 2022
@weefuzzy
Copy link
Member Author

The gospel seems to be

https://github.com/pure-data/pure-data/blob/18c9695ba4de543c51c2c013b45b99b8f1c35a19/src/s_loader.c#L32-L38

According to which .l_ia64 is accepted but wrong and would actually be .l_amd64 for linux, .d_amd64 on mac and so forth.

@jamesb93 jamesb93 modified the milestones: beta8, Version 1.0 Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weefuzzy weefuzzy

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
3 participants
@tremblap @jamesb93 @weefuzzy