Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Auto increment field, Link field is created as varchar so when joining the table query is running slow due to data type missmatch. #26111

Open
amrishshah opened this issue Apr 23, 2024 · 2 comments

Comments

@amrishshah
Copy link

I purpose following changes in the file apps/frappe/frappe/database/schema.py

In Class DbColumn

image

Pass variable to get_definition as shown below

image

Pass variable in build_for_alter_table as shown below

image

Make changes in the get_definition function

image

Actual is_link_doctype_autoincrement function

image

Complete File
schema.txt

@amrishshah amrishshah added the bug label Apr 23, 2024
@amrishshah
Copy link
Author

Also casting need to be done for second part as mentioned in #24454

@ankush ankush added performance and removed bug labels Apr 24, 2024
@ankush
Copy link
Member

ankush commented Apr 24, 2024

related: #25310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants