Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16] Move away from using email ID as username #26189

Open
ankush opened this issue Apr 29, 2024 · 1 comment
Open

[v16] Move away from using email ID as username #26189

ankush opened this issue Apr 29, 2024 · 1 comment
Labels
breaking change feature-request refactor

Comments

@ankush
Copy link
Member

ankush commented Apr 29, 2024 •
edited

Email ID as user name is bad idea, emails change all the time, Frappe itself has changed it thrice and now all of our employees have mixed user names. There's x@erpnext.com, y@iwebnotes.com and z@frappe.io.

Changes:

  • User ID should become the name, it can be set by user. E.g. ankush instead of ankush@frappe.io
  • All the code that sends email should fetch email id field based on user id field.
  • Disable user ID rename, not required anymore.
  • Handle ldap and other login providers. (Should work fine for existing sites and new sites)
@ankush ankush changed the title [v16] Move away from using email ID as user name [v16] Move away from using email ID as username Apr 29, 2024
@nikkothari22 nikkothari22 mentioned this issue Apr 29, 2024
Open
@HUMENTH
Copy link
Contributor

HUMENTH commented May 4, 2024

@ankush
If there are users such as
himanshu@abc.com,
himanshu@xyz.com, and
himanshu@abyz.com,
Frappe will determine which user ID to consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change feature-request refactor
Projects
Framework v16
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HUMENTH @ankush