You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cssutils throws false warnings and errors for css properties that acutally have an effect on the style of the pdf.
The generated frappe reports throw errors into the bench start output.
Additionally I have a report in my app that is a bit more complex and because of this I have a few extra styles in this report. These stlyes are neccessary and work in the report, however cssutils throws them as errors.
Ideas for solutions
cssutils should only thrown errors or warnings if wkhtmltopdf really has problems with the properties, since it is very confusing.
Another option would be to suppress these errors since appreantly they are neihter usefull nor helpful.
Context information (for bug reports)
Output of bench version
I have tried this on two machnies one with frappe v14 in the following versions
erpnext 14.68.2
frappe 14.72.0
and one with frappe v15 in the this version
frappe 15.24.1
Steps to reproduce the issue
open the PDF of a Report (e.g. the PDF to a User Doc)
look into the bench start output
you see the errors
Observed result
the given errors appear in the console, even though the report is created and the styles are used correctly.
Expected result
No errors should be thrown. If an error is thrown the message should be correct, since cssutils marks properties as wrong that work in the reports.
Stacktrace / full error message
These errors will appear in the output of the bench start
Description of the issue
cssutils throws false warnings and errors for css properties that acutally have an effect on the style of the pdf.
The generated frappe reports throw errors into the bench start output.
Additionally I have a report in my app that is a bit more complex and because of this I have a few extra styles in this report. These stlyes are neccessary and work in the report, however cssutils throws them as errors.
Ideas for solutions
cssutils should only thrown errors or warnings if wkhtmltopdf really has problems with the properties, since it is very confusing.
Another option would be to suppress these errors since appreantly they are neihter usefull nor helpful.
Context information (for bug reports)
Output of
bench version
I have tried this on two machnies one with frappe v14 in the following versions
and one with frappe v15 in the this version
Steps to reproduce the issue
Observed result
the given errors appear in the console, even though the report is created and the styles are used correctly.
Expected result
No errors should be thrown. If an error is thrown the message should be correct, since cssutils marks properties as wrong that work in the reports.
Stacktrace / full error message
These errors will appear in the output of the bench start
Additional information
I am using the Ubuntu 22.04.3 LTS.
The text was updated successfully, but these errors were encountered: