New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better "remove empty rows" #26270

Open

ankush opened this issue May 1, 2024 · 0 comments · May be fixed by #26315

Labels

feature-request

Member

ankush commented May 1, 2024 •

edited

Currently we check if any "in list view" fields are falsy, if so we remove the row. This is confusing behaviour so I removed it here: #26269

A better fix probably:

Flag new rows as undirty
When new row is modified, make them dirty
When saving remove new, undirty rows.

This doesn't work with scripts modifying newly created row mostly.

This still has a lot of ways to go wrong, maybe we shouldn't have this feature at all.

ankush added the feature-request label

ssuda linked a pull request

that will close this issue

fix: remove empty rows #26315

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment