Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation bug on changing Status field in Job Opening Doctype #1575

Open
1 task done
zuron7 opened this issue Mar 25, 2024 · 0 comments · May be fixed by #1610
Open
1 task done

validation bug on changing Status field in Job Opening Doctype #1575

zuron7 opened this issue Mar 25, 2024 · 0 comments · May be fixed by #1610
Assignees
Labels
bug Something isn't working to-validate

Comments

@zuron7
Copy link
Contributor

zuron7 commented Mar 25, 2024

Information about bug

When changing status of a Job Opening, the following error pops up:

image

I've identified that the error is from the file below and it seems the validation is checking if the number of opening is less than that number of people working at the organization + the number of job openings for that position.

I think the validation needs to be changed to be only to compare against the number of job openings. The reason we got this error was that we had a few people already with this position who were given an offer without a job opening created for this.

Link to Code Section

I fixed it on our instance by marking some employees as inactive for some time to allow for the job opening to be closed.

Module

HR

Version

Frappe v15.18.2
ERPNext v15.17.5
Frappe HR v15.14.2

Installation method

FrappeCloud

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@zuron7 zuron7 added the bug Something isn't working label Mar 25, 2024
@zuron7 zuron7 changed the title Validation bug on changing Status Field in Job Opening Doctype validation bug on changing Status field in Job Opening Doctype Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to-validate
Projects
None yet
3 participants