Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki not loading for user without System Admin and Wiki Approval role #172

Closed
nilpatel42 opened this issue Jul 17, 2023 · 9 comments
Closed

Comments

@nilpatel42
Copy link

nilpatel42 commented Jul 17, 2023

When i add Wiki Approval Permission but i tick "if created by" then it not working, it show many redirect error
Wiki version : v2.0.0 (version-14)
ERPNext : v14.27.12 (version-14)
Frappe Framework : v14.40.0 (version-14)

In Firefox
image

and i also add code in terminal

/frappe-bench/apps/frappe/frappe/utils/caching.py:57: DeprecationWarning: `frappe_last` argument is deprecated and will be removed in v15.
17:52:45 web.1            |   return_val = func(*args, **kwargs)
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /login?redirect-to=http%3A%2F%2F192.168.1.147%3A8000%2Fwiki%2Fabout-abc HTTP/1.1" 301 -
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /wiki/about-abc HTTP/1.1" 301 -
17:52:45 web.1            | /home/abc/frappe-bench/apps/frappe/frappe/utils/caching.py:57: DeprecationWarning: `frappe_last` argument is deprecated and will be removed in v15.
17:52:45 web.1            |   return_val = func(*args, **kwargs)
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /login?redirect-to=http%3A%2F%2F192.168.1.147%3A8000%2Fwiki%2Fabout-abc HTTP/1.1" 301 -
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /wiki/about-abc HTTP/1.1" 301 -
17:52:45 web.1            | /home/abc/frappe-bench/apps/frappe/frappe/utils/caching.py:57: DeprecationWarning: `frappe_last` argument is deprecated and will be removed in v15.
17:52:45 web.1            |   return_val = func(*args, **kwargs)
17:52:45 web.1            | /home/abc/frappe-bench/apps/frappe/frappe/utils/caching.py:57: DeprecationWarning: `frappe_last` argument is deprecated and will be removed in v15.
17:52:45 web.1            |   return_val = func(*args, **kwargs)
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /login?redirect-to=http%3A%2F%2F192.168.1.147%3A8000%2Fwiki%2Fabout-abc HTTP/1.1" 301 -
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /website_script.js HTTP/1.1" 200 -
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /wiki/about-abc HTTP/1.1" 301 -
17:52:45 web.1            | /home/abc/frappe-bench/apps/frappe/frappe/utils/caching.py:57: DeprecationWarning: `frappe_last` argument is deprecated and will be removed in v15.
17:52:45 web.1            |   return_val = func(*args, **kwargs)
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /login?redirect-to=http%3A%2F%2F192.168.1.147%3A8000%2Fwiki%2Fabout-abc HTTP/1.1" 301 -
17:52:45 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:45] "GET /wiki/about-abc HTTP/1.1" 301 -
17:52:46 web.1            | /home/abc/frappe-bench/apps/frappe/frappe/utils/caching.py:57: DeprecationWarning: `frappe_last` argument is deprecated and will be removed in v15.
17:52:46 web.1            |   return_val = func(*args, **kwargs)
17:52:46 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:46] "GET /login?redirect-to=http%3A%2F%2F192.168.1.147%3A8000%2Fwiki%2Fabout-abc HTTP/1.1" 301 -
17:52:46 web.1            | 192.168.1.210 - - [17/Jul/2023 17:52:46] "GET /wiki/about-abc HTTP/1.1" 301 -

This code run repetitively when i refresh or trying to get wiki page

@BreadGenie
Copy link
Member

Sorry I didn't get what you meant by "if created by" in the description. Can you elaborate a bit more on that?

@nilpatel42
Copy link
Author

Sorry I didn't get what you meant by "if created by" in the description. Can you elaborate a bit more on that?

sorry
its If only Creator

@BreadGenie
Copy link
Member

Sorry but where is the "it's if only creator" field at?

@nilpatel42
Copy link
Author

nilpatel42 commented Jul 17, 2023

Sorry but where is the "it's if only creator" field at?

in role permission manager,
every permission have this checkbox

Screenshot_20230717_195918_Brave.jpg

@BreadGenie
Copy link
Member

BreadGenie commented Jul 17, 2023

In what doctype did you change it?
I enabled the "Only if Creator" from role perm manager to all wiki doctypes and it works fine for me (opened it as guest too)

@nilpatel42
Copy link
Author

In what doctype did you change it?
I enabled the "Only if Creator" from role perm manager to all wiki doctypes and it works fine for me (opened it as guest too)

  • first problem is without given user to wiki aproover role or admin , wiki not working (my all wiki page is disabled for guest)
  • When i enable the checkbox in wiki page doctype, its not working
  • but when it disable and wiki aproover role given to user its working

@BreadGenie
Copy link
Member

BreadGenie commented Jul 17, 2023

Are you trying to make it so that the creators of the page only can view the wiki page?

If yes that's not the purpose of Wiki. It's supposed to host content/documentation that's supposed to be shared among others (public or within your team (read no guests allowed))

Since it's designed with that in mind you'll have troubles trying to use Wiki that way

@nilpatel42
Copy link
Author

okay i understand
i want share docs within my team
but why user not access wiki when wiki approver or admin role not assign
if i am correct without that both role wiki must accessible to users who have login credentials to ERPNext

Thank you

@BreadGenie
Copy link
Member

if i am correct without that both role wiki must accessible to users who have login credentials to ERPNext

You're right the pages can be made inaccessible to only guests atm.

There's an ongoing issue #60 that tracks the feature that you want.

@BreadGenie BreadGenie closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants