Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Colors and Fonts #92

Open
barredterra opened this issue Jul 17, 2022 · 4 comments
Open

Configurable Colors and Fonts #92

barredterra opened this issue Jul 17, 2022 · 4 comments

Comments

@barredterra
Copy link
Contributor

Issue

Currently, wiki defines its own style, separate from the rest of the website, which gets included in wiki pages only. This way, it's also not configurable.

Proposed solution

For usual web pages we can define colors, fonts, etc. in Website Theme. IMHO, this should apply to wiki as well.

We can achieve this by creating a website.bundle.scss, which imports all the wiki styles. We'll need to scope the styles to apply to wiki pages only, avoiding to mess up the rest of the website.

@hasnain2808
Copy link
Contributor

wiki uses the variables defined by the website theme so changing that should change wiki too

@barredterra
Copy link
Contributor Author

That's what I expected, but it doesn't

@hasnain2808
Copy link
Contributor

hasnain2808 commented Jul 23, 2022

That's weird
We remember breaking our internal wiki by adding custom CSS/ js for webpages

Full theme capabilities support would be cool though

@barredterra
Copy link
Contributor Author

Yes, I can imagine that you had problems this way around.

Website Theme only takes into account website.bundle.scss. But wiki doesn't provide this file. Instead it has several CSS files that get included in the specific pages directly. This way it cannot access the fonts and colors defined in Website Theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants