Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vuls discover CIDR #1540

Open
fabianhjr opened this issue Oct 5, 2022 · 3 comments
Open

vuls discover CIDR #1540

fabianhjr opened this issue Oct 5, 2022 · 3 comments
Labels

Comments

@fabianhjr
Copy link

fabianhjr commented Oct 5, 2022

What did you do? (required. The issue will be closed when not provided.)

Want to auto-discover (generate a lot of configs) regarding servers on 10.x.1._, 10.x.2._, 10.x.3._, ... (10.x.1.0/24, 10.x.2.0/24, ...) so attempted 10.x.0.0/21 which should cover 10.x.0.1 - 10.x.7.254 (enough for my use case)

vuls discover 10.x.0.0/21                                                   139ms  Tue 04 Oct 2022 07:29:33 PM CDT
[Oct  4 19:31:19]  INFO [localhost] vuls-v0.20.5-build-20221004_192434_eb87d5d
[Oct  4 19:33:00] ERROR [localhost] Active hosts not found in 10.x.0.0/21

However:

vuls discover 10.x.1.0/24

Does result in servers being discovered and should have been part of the auto-discovery for the bigger network/smaller mask.

What did you expect to happen?

Autodiscovery of a subset of a net being part of autodiscovery of a bigger net

What happened instead?

  • Current Output

Please re-run the command using -debug and provide the output below.

Steps to reproduce the behaviour:

Attempt a partial CIDR such as /21 on a 10.0.0.0/8 local network

  • Go version (go version): go version go1.18.6 linux/amd64

  • Go environment (go env):

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/fabian/.cache/go-build"
GOENV="/home/fabian/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/fabian/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/fabian/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/nix/store/2gkzvf10bng6x2kj521fkg1915v2z76v-go-1.18.6/share/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/nix/store/2gkzvf10bng6x2kj521fkg1915v2z76v-go-1.18.6/share/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.6"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/fabian/Development/Open/vuls/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
  • Vuls environment:

commit eb87d5d (HEAD -> master, tag: v0.20.5, origin/master, origin/HEAD)

  • config.toml:

N/A

  • command:

vuls discover

@fabianhjr fabianhjr added the bug label Oct 5, 2022
@MaineK00n
Copy link
Collaborator

@fabianhjr
Thanks for the report.

For example, the server on 10.x.1.1 is active.
Perform vuls discover in two ranges: 10.x.0.0/21 (10.x.0.0 - 10.x.7.255) and 10.x.1.0/24 (10.x.1.0 - 10.x.1.255).
The 10.x.1.1 server is in both ranges and should be detected in both ranges, but in your environment it was only detected at 10.x.1.0/24.
The problem you are experiencing in your environment is this situation?

Does this always reproduce in your environment?

@fabianhjr
Copy link
Author

The problem you are experiencing in your environment is this situation?

Yes, vuls discovered servers with 10.x.1.0/24 but not with 10.x.0.0/21

There are no servers on 10.x.0.0/24 and the first one is on 10.x.1.0/24; I am unfamiliar with the codebase to be sure if some laziness code would stop discovery upon an empty /24.

@fabianhjr
Copy link
Author

Was able to reproduce again today:

./vuls discover 10.x.0.0/21                                                1.2m  Mon 10 Oct 2022 08:44:37 PM CDT
[Oct 10 20:44:40]  INFO [localhost] vuls-v0.20.5-build-20221004_192434_eb87d5d
[Oct 10 20:46:20] ERROR [localhost] Active hosts not found in 10.x.0.0/21

vs

./vuls discover 10.x.1.0/24                                                   30.2s  Mon 10 Oct 2022 08:44:11 PM CDT
[Oct 10 20:44:45]  INFO [localhost] vuls-v0.20.5-build-20221004_192434_eb87d5d
# Create config.toml using below and then ./vuls -config=/path/to/config.toml
[...] // Configs / IPs redacted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants