Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for DWD in g/g #9535

Open
rishabh-11 opened this issue Apr 5, 2024 · 1 comment
Open

Add e2e tests for DWD in g/g #9535

rishabh-11 opened this issue Apr 5, 2024 · 1 comment
Assignees
Labels
area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension kind/test Test priority/3 Priority (lower number equals higher priority)

Comments

@rishabh-11
Copy link
Contributor

How to categorize this issue?

/area performance
/area quality
/kind test
/priority 3

What would you like to be added:
We need to add e2e tests in g/g for DWD.

Why is this needed:

The current problem that we have is for DWD to work as expected, there are specific changes done in g/g (See #9072 and #9339). The problem is any change made in DWD might require a change in g/g as well (like in the case of gardener/dependency-watchdog#106 we needed to adapt g/g to give node access permissions for DWD service account, which we forgot to do before making a DWD release). If we had e2e tests for DWD in g/g this problem will not happen as it will be caught before the new version of DWD is merged in g/g.

@rishabh-11 rishabh-11 added the kind/enhancement Enhancement, improvement, extension label Apr 5, 2024
@gardener-prow gardener-prow bot added area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/test Test priority/3 Priority (lower number equals higher priority) labels Apr 5, 2024
@rishabh-11 rishabh-11 self-assigned this Apr 5, 2024
@ashwani2k ashwani2k transferred this issue from gardener/dependency-watchdog Apr 5, 2024
@acumino
Copy link
Member

acumino commented Apr 5, 2024

Wouldn't it be better to add the test in DWD instead, extensions that need to test functionality specific to the extension add e2e tests in their own repo. You can check one such example here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension kind/test Test priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

2 participants