Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"--attempt-instant-ddl" flag causing some issues with hooks and is incompatible with --execute flag #1365

Open
YazanNoon opened this issue Jan 8, 2024 · 1 comment
Labels

Comments

@YazanNoon
Copy link

YazanNoon commented Jan 8, 2024

when I tried to use the --attempt-instant-ddl flag, I faced two issues:

  • the on-success hook will not trigger after the migration is done.
  • even if I don't use the --execute flag, the migration will still happen anyway.
@hakusaro
Copy link

hakusaro commented Apr 3, 2024

If it's not too much effort @timvaillancourt, I would suggest adding this to the docs around --attempt-instant-ddl, as looking at this, the original PR, and other issues led me to pulling this flag out of our production gh-ost scripts for safety.

I know you're very busy, and this is a low priority task, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@hakusaro @timvaillancourt @YazanNoon and others