Issues building on Ubuntu

[MaineC]

Hi,

I tried building the project by running make test today (before making changes to the code, or more precisely after reverting the changes I already had made ;) ). Doing so I ran into a few issues. Can you share the environment that you use to for building and testing this action? (I don't regularly write Python code, so likely I'm missing something really obvious here).

Lengthy error message including info on environment I got below:

issue-metrics (main) $ make test
pytest -v --cov=. --cov-config=.coveragerc --cov-fail-under=80 --cov-report term-missing
=========================================================================================== test session starts ===========================================================================================
platform linux -- Python 3.10.12, pytest-7.4.2, pluggy-1.0.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /home/isabel/projects/oss/issue-metrics
plugins: cov-4.1.0
collected 35 items / 2 errors                                                                                                                                                                             

================================================================================================= ERRORS ==================================================================================================
_________________________________________________________________________________ ERROR collecting test_issue_metrics.py __________________________________________________________________________________
/usr/local/lib/python3.10/dist-packages/_pytest/runner.py:341: in from_call
    result: Optional[TResult] = func()
/usr/local/lib/python3.10/dist-packages/_pytest/runner.py:372: in <lambda>
    call = CallInfo.from_call(lambda: list(collector.collect()), "collect")
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:531: in collect
    self._inject_setup_module_fixture()
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:545: in _inject_setup_module_fixture
    self.obj, ("setUpModule", "setup_module")
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:310: in obj
    self._obj = obj = self._getobj()
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:528: in _getobj
    return self._importtestmodule()
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:617: in _importtestmodule
    mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
/usr/local/lib/python3.10/dist-packages/_pytest/pathlib.py:567: in import_path
    importlib.import_module(module_name)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:1006: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:688: in _load_unlocked
    ???
/usr/local/lib/python3.10/dist-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
test_issue_metrics.py:20: in <module>
    import issue_metrics
issue_metrics.py:35: in <module>
    from labels import get_average_time_in_labels, get_label_metrics
labels.py:13: in <module>
    ) -> List[github3.issues.event]:  # type: ignore
/usr/lib/python3.10/typing.py:312: in inner
    return func(*args, **kwds)
/usr/lib/python3.10/typing.py:1143: in __getitem__
    params = tuple(_type_check(p, msg) for p in params)
/usr/lib/python3.10/typing.py:1143: in <genexpr>
    params = tuple(_type_check(p, msg) for p in params)
/usr/lib/python3.10/typing.py:176: in _type_check
    raise TypeError(f"{msg} Got {arg!r:.100}.")
E   TypeError: Parameters to generic types must be types. Got <module 'github3.issues.event' from '/home/isabel/.local/lib/python3.10/site-packages/github3/issues.
_____________________________________________________________________________________ ERROR collecting test_labels.py _____________________________________________________________________________________
/usr/local/lib/python3.10/dist-packages/_pytest/runner.py:341: in from_call
    result: Optional[TResult] = func()
/usr/local/lib/python3.10/dist-packages/_pytest/runner.py:372: in <lambda>
    call = CallInfo.from_call(lambda: list(collector.collect()), "collect")
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:531: in collect
    self._inject_setup_module_fixture()
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:545: in _inject_setup_module_fixture
    self.obj, ("setUpModule", "setup_module")
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:310: in obj
    self._obj = obj = self._getobj()
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:528: in _getobj
    return self._importtestmodule()
/usr/local/lib/python3.10/dist-packages/_pytest/python.py:617: in _importtestmodule
    mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
/usr/local/lib/python3.10/dist-packages/_pytest/pathlib.py:567: in import_path
    importlib.import_module(module_name)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1027: in _find_and_load
    ???
<frozen importlib._bootstrap>:1006: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:688: in _load_unlocked
    ???
/usr/local/lib/python3.10/dist-packages/_pytest/assertion/rewrite.py:178: in exec_module
    exec(co, module.__dict__)
test_labels.py:10: in <module>
    from labels import get_average_time_in_labels, get_label_events, get_label_metrics
labels.py:13: in <module>
    ) -> List[github3.issues.event]:  # type: ignore
/usr/lib/python3.10/typing.py:312: in inner
    return func(*args, **kwds)
/usr/lib/python3.10/typing.py:1143: in __getitem__
    params = tuple(_type_check(p, msg) for p in params)
/usr/lib/python3.10/typing.py:1143: in <genexpr>
    params = tuple(_type_check(p, msg) for p in params)
/usr/lib/python3.10/typing.py:176: in _type_check
    raise TypeError(f"{msg} Got {arg!r:.100}.")
E   TypeError: Parameters to generic types must be types. Got <module 'github3.issues.event' from '/home/isabel/.local/lib/python3.10/site-packages/github3/issues.

---------- coverage: platform linux, python 3.10.12-final-0 ----------
Name                          Stmts   Miss  Cover   Missing
-----------------------------------------------------------
classes.py                        8      6    25%   33-38
discussions.py                   14     12    14%   24-72
issue_metrics.py                142    132     7%   36-356
json_writer.py                   29     23    21%   74-127
labels.py                        58     52    10%   24-119
markdown_writer.py               72     65    10%   45-64, 98-162, 178-196
time_to_answer.py                25     20    20%   30-51, 64-74
time_to_close.py                 33     27    18%   39-54, 71-92
time_to_first_response.py        61     55    10%   47-109, 124-144
time_to_merge.py                 12      8    33%   33-43
time_to_ready_for_review.py      11      7    36%   36-44
-----------------------------------------------------------
TOTAL                           465    407    12%

FAIL Required test coverage of 80% not reached. Total coverage: 12.47%
========================================================================================= short test summary info =========================================================================================
ERROR test_issue_metrics.py - TypeError: Parameters to generic types must be types. Got <module 'github3.issues.event' from '/home/isabel/.local/lib/python3.10/site-packages/github3/issues.
ERROR test_labels.py - TypeError: Parameters to generic types must be types. Got <module 'github3.issues.event' from '/home/isabel/.local/lib/python3.10/site-packages/github3/issues.
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================================================================================ 2 errors in 0.89s ============================================================================================
make: *** [Makefile:3: test] Error 2

`

[zkoppert]

Interesting that these failures showed up. It is very straight forward to me what the issue is given these errors.

Here are the instructions from the README.md on local usage: https://github.com/github/issue-metrics#local-usage-without-docker

Were you able to successfully complete those steps without error? Particularly interested in the pip3 install -r requirements.txt step.

[MaineC]

I checked the instruction on local usage. The pip3 install -r requirements.txt step I remember did run through successfully. When running that again it tells me that all requirements are already satisfied.

Running ./issue_metrics.py directly gives me pretty much the same type error as above

Traceback (most recent call last):
  File "/home/isabel/projects/oss/issue-metrics/./issue_metrics.py", line 35, in <module>
    from labels import get_average_time_in_labels, get_label_metrics
  File "/home/isabel/projects/oss/issue-metrics/labels.py", line 13, in <module>
    ) -> List[github3.issues.event]:  # type: ignore
  File "/usr/lib/python3.10/typing.py", line 312, in inner
    return func(*args, **kwds)
  File "/usr/lib/python3.10/typing.py", line 1143, in __getitem__
    params = tuple(_type_check(p, msg) for p in params)
  File "/usr/lib/python3.10/typing.py", line 1143, in <genexpr>
    params = tuple(_type_check(p, msg) for p in params)
  File "/usr/lib/python3.10/typing.py", line 176, in _type_check
    raise TypeError(f"{msg} Got {arg!r:.100}.")
TypeError: Parameters to generic types must be types. Got <module 'github3.issues.event' from '/home/isabel/.local/lib/python3.10/site-packages/github3/issues.
 

[MaineC]

Looks like the Python3 version that current Unbuntu LTS ships by default was too old.

Thanks to your colleague @t-lo for the quick lunch-break debugging support.

[zkoppert]

✨ @t-lo !

[zkoppert]

Can you share what version of python you upgraded to? I'd like to put this in a debugging section of the readme for others in case they run into the same issue.

[zkoppert]

Oh, nevermind. I see you are a few steps ahead of me. haha I just saw your PR. Thank you!! #125

[t-lo]

Python 3.10 broke this, python 3.11 worked. My assumption is that whatever type caused 3.10 to break isn't supported by typing.py in 3.10 but has support in 3.11. It seems that quite a few types have been added in 3.11 specifically: https://docs.python.org/3/library/typing.html .