Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to compare large results #1364

Open
JarLob opened this issue May 25, 2022 · 2 comments
Open

Failure to compare large results #1364

JarLob opened this issue May 25, 2022 · 2 comments
Labels
bug Something isn't working VSCode

Comments

@JarLob
Copy link
Contributor

JarLob commented May 25, 2022

Describe the bug
CodeQL fails to "Compare Results"

Version

CodeQL extension version: 1.6.6
CodeQL CLI version: 2.9.2
Platform: win32 x64

Version: 1.67.2 (user setup)
Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5
Date: 2022-05-17T18:15:52.058Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Windows_NT x64 10.0.19044

To reproduce
Get codeql database from https://bug-bounty-codeql-databases.s3.us-east-2.amazonaws.com/codeql-db-100-cpp.tar.xz
Query it first for

import cpp
from Variable var
select var

then for

import cpp
from LocalVariable var
select var

In the Query Results window select both rows, right click and "Compare Results"

Observe an error message "Reading bqrs data failed: Error: Cannot create a string longer than 0x1fffffe8 characters"

Expected behavior
See the difference between two results

@JarLob JarLob added the bug Something isn't working label May 25, 2022
@aeisenberg
Copy link
Contributor

Thank you for reporting this issue. The extension cannot handle comparisons of such large results sets. This is because in order to compare results, we need to load both results sets into memory.

@JarLob
Copy link
Contributor Author

JarLob commented May 25, 2022

Maybe algorithm can be changed... From the error message it sounds like it tries to create a single huge string.

@charisk charisk assigned charisk and unassigned charisk May 31, 2022
@charisk charisk removed their assignment Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

No branches or pull requests

3 participants