Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: don't suggest simplification of "for _ = range x" if x is a func #67394

Closed
adonovan opened this issue May 15, 2024 · 1 comment
Closed

x/tools/gopls: don't suggest simplification of "for _ = range x" if x is a func #67394

adonovan opened this issue May 15, 2024 · 1 comment
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools
Milestone
gopls/v0.16.0

Comments

@adonovan
Copy link
Member

adonovan commented May 15, 2024 •
edited

Currently, the spec requires that a for _ = range f statement must have the blank variables (one for Seq, two for Seq2). Gopls currently suggests a simplification to for range f. It should not do that.

But first wait for a decision on this proposal:
@adonovan adonovan added the gopls Issues related to the Go language server, gopls. label May 15, 2024
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label May 15, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 15, 2024
@adonovan adonovan added Refactoring Issues related to refactoring tools and removed Tools This label describes issues relating to any tools in the x/tools repository. labels May 15, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 May 15, 2024
@adonovan adonovan self-assigned this May 16, 2024
@findleyr
Copy link
Contributor

Deduping to #67239, which is more general.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools
Projects
None yet
Milestone
gopls/v0.16.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr