Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/telemetry/godev: telemetry.go.dev chart view is broken #67397

Closed
hyangah opened this issue May 15, 2024 · 1 comment
Closed

x/telemetry/godev: telemetry.go.dev chart view is broken #67397

hyangah opened this issue May 15, 2024 · 1 comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented May 15, 2024

https://telemetry.go.dev/charts/2024-05-07

Screenshot 2024-05-15 at 3 24 48 PM

It was broken from 05/07 because the worker produces chart json file with unexpected Charts in it.

{
    "DateRange": [
        "2024-05-13",
        "2024-05-13"
    ],
    "Programs": [
        {
            "ID": "charts:cmd/compile",
            "Name": "cmd/compile",
            "Charts": [
                null,
                null,
                null,
                null,
                null
            ]
        },
        {
            "ID": "charts:cmd/go",
            "Name": "cmd/go",
            "Charts": [
                null,
                null,
                null,
                null,
                null,
                null
            ]
        },
        ...

And, that caused https://go.googlesource.com/telemetry/+/refs/heads/master/internal/content/telemetrygodev/charts.ts#41 failed.

@gopherbot gopherbot added the telemetry x/telemetry issues label May 15, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 15, 2024
@gopherbot
Copy link

Change https://go.dev/cl/585479 mentions this issue: godev/cmd/worker: skip empty partition in charts

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

3 participants