Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GELU support in XNNPACK #5753

Open
phoebesv opened this issue Nov 15, 2023 · 4 comments
Open

GELU support in XNNPACK #5753

phoebesv opened this issue Nov 15, 2023 · 4 comments

Comments

@phoebesv
Copy link
Contributor

phoebesv commented Nov 15, 2023

We would like to contribute rvv GELU in XNNPACK.
Does the XNNPACK plan to support GELU (related APIs, scalar code and TFLite delegation, etc.) ?
This is required for bert models (e.g. bert_base and bert_large)

@bhbruce
Copy link
Contributor

bhbruce commented Nov 20, 2023

Hi @fbarchard @Maratyszcza

Do you have any suggestions about this Op?

@ngzhian
Copy link
Collaborator

ngzhian commented Nov 20, 2023

@alankelly i think Marat wanted to support this but was not prioritized. see b/272379108

@alankelly
Copy link
Collaborator

GELU is not on our roadmap, however, please feel free to add the required operator & subgraph support & scalar microkernels.

XNNPACK has strict precision requirements, the maximum error of your implementation will have to be found via exhaustive testing.

@phoebesv
Copy link
Contributor Author

Thank you for your response. We will consider and explore the addition of the required operator, subgraph support, and scalar microkernels for GELU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants