Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XNN_FLAG_KEEP_DIM not backwards compatible #6090

Open
mcr229 opened this issue Feb 27, 2024 · 1 comment
Open

XNN_FLAG_KEEP_DIM not backwards compatible #6090

mcr229 opened this issue Feb 27, 2024 · 1 comment

Comments

@mcr229
Copy link
Contributor

mcr229 commented Feb 27, 2024

Commit:
23f386b

Introduces the XNN_FLAG_KEEP_DIM flag which makes global_sum_pooling, global_average_pooling, and static mean no longer backwards compatible. That is calls previously to

xnn_define_global_average_pooling will reduce dims, when previous to this commit they would not. I would like to suggest that this flag be changed to XNN_FLAG_REDUCE_DIMS. This way previous calls to global_sum_pooling, global_average_pooling, and static mean is not changed(keep dim is on by deafult) , and instead we opt-in to reducing dims with this flag.

PR for change is here:
#6089

@mcr229
Copy link
Contributor Author

mcr229 commented Mar 14, 2024

hi @alankelly, I noticed that these changes were rolled back. Is that the intention for the future going forward? Just want to know now to understand whether or not the commit with flag_reduce_dims is stable or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant