Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default condition missing for xnnpack_aggregate_library #6359

Closed
Nayana-ibm opened this issue May 2, 2024 · 1 comment · Fixed by #6391
Closed

Default condition missing for xnnpack_aggregate_library #6359

Nayana-ibm opened this issue May 2, 2024 · 1 comment · Fixed by #6391

Comments

@Nayana-ibm
Copy link

Default condition is missing for xnnpack_aggregate_library.
This causes TensorFlow build to fail on s390x

@Nayana-ibm
Copy link
Author

Below patch adds default condition.

diff --git a/build_defs.bzl b/build_defs.bzl
index db0ee74f2..afec3a98c 100644
--- a/build_defs.bzl
+++ b/build_defs.bzl
@@ -260,6 +260,7 @@ def xnnpack_aggregate_library(
             "//build_config:emscripten_wasmsimd": wasmsimd_deps,
             "//build_config:emscripten_wasmrelaxedsimd": wasmrelaxedsimd_deps,
             "//build_config:riscv": riscv_deps,
+           "//conditions:default": [],
         }),
         defines = defines,
         compatible_with = compatible_with,

Let me know if PR needs to be raised.

@Nayana-ibm Nayana-ibm changed the title Default condition is missing for xnnpack_aggregate_library Default condition missing for xnnpack_aggregate_library May 2, 2024
copybara-service bot pushed a commit that referenced this issue May 8, 2024
- Fixes TensorFlow build on s390x
- Remove internal gcc -Wgnu-empty-struct which is not supported on GCC version 13

Fixes #6359

PiperOrigin-RevId: 631870251
copybara-service bot pushed a commit that referenced this issue May 8, 2024
- Fixes TensorFlow build on s390x
- Remove internal gcc -Wgnu-empty-struct which is not supported on GCC version 13

Fixes #6359

PiperOrigin-RevId: 631870251
copybara-service bot pushed a commit that referenced this issue May 8, 2024
- Fixes TensorFlow build on s390x
- Remove internal gcc -Wgnu-empty-struct which is not supported on GCC version 13

Fixes #6359

PiperOrigin-RevId: 631870251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant