Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for including/excluding license rollup #19

Open
kaugesaar opened this issue Aug 9, 2023 · 5 comments
Open

Add flag for including/excluding license rollup #19

kaugesaar opened this issue Aug 9, 2023 · 5 comments

Comments

@kaugesaar
Copy link

I'd be happy to work on this feature myself. However, before diving in, I wanted to check whether it's within the project's scope. Would you accept a pull request for this? If it's in scope, what would be the preferred method: including or excluding the rollup via a flag?

@paranerd
Copy link
Collaborator

Hi!
Thanks for checking this out.
Just for my understanding: what exactly do you mean by "license rollup"? The behavior to only keep one license header in the final output?

@kaugesaar
Copy link
Author

Yeah, exactly. Though I did also noticed now that it does have a script to add a license header too "all" other files as well. So the final feature would involve more than just the rollup plugin.

But basically a flag to toggle this part in rollup.config.mjs and its dependencies:

https://github.com/google/aside/blob/main/rollup.config.mjs#L30-L36

  license({
    banner: {
      content: {
        file: fileURLToPath(new URL('license-header.txt', import.meta.url)),
      },
    },
  }),

Plus the license-check-and-add dependency and its associated script and files.

Right not I'm removing all of it manually, which to be fair is not much work, but would be nice to be able to do it on init.

@paranerd
Copy link
Collaborator

So basically the aim would be to keep the license situation untouched (don't add and don't remove), correct?

@kaugesaar
Copy link
Author

Yes the aim would be to leave it untouched in that sense. But on init you could potentially then have a flag such as:

npx @google/aside init --no-license-header

@paranerd
Copy link
Collaborator

Wouldn't --no-license-modification or something similar be more descriptive of what's supposed to happen (which is 'nothing'^^)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants