Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cdhash, teamID, signingID to the bundle events #1353

Merged

Conversation

np5
Copy link
Contributor

@np5 np5 commented May 17, 2024

Fix #1352

@np5 np5 requested a review from a team as a code owner May 17, 2024 08:29
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix the signingID formatting.

Source/santabundleservice/SNTBundleService.m Outdated Show resolved Hide resolved
@np5 np5 force-pushed the 20240517_bundle_event_extra_attrs branch from 95cb309 to 64b366b Compare May 20, 2024 08:49
@mlw mlw added this to the 2024.5 milestone May 20, 2024
@russellhancox russellhancox enabled auto-merge (squash) May 20, 2024 14:26
@russellhancox russellhancox merged commit d8928ac into google:main May 20, 2024
12 checks passed
@np5 np5 deleted the 20240517_bundle_event_extra_attrs branch May 20, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Signing ID and Team ID to the Bundle Binary events
4 participants