Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updateDocument mask default to true #169

Open
legenduzo opened this issue Dec 2, 2023 · 0 comments
Open

Make updateDocument mask default to true #169

legenduzo opened this issue Dec 2, 2023 · 0 comments

Comments

@legenduzo
Copy link

Please consider making the mask in updateDocument(path, fields, mask = false) true instead of false.

By default the expectation of the end-user is that the fields specified in fields are updated and it comes as a rude shock if the whole document is overwritten and it's just their new update that is reflected.

Defaulting mask = true will be consistent with document updates, with the optional choice of overwriting the whole document by consciously setting it to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant