Remove denied AWS Roles in AWS Role Web picker #41585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I delete all my non-aws apps, it looks like it fixes the login dropdown issue though :D thanks for the fast work!
|
GavinFrazar
reviewed
May 16, 2024
lib/services/access_checker.go
Outdated
Comment on lines
787
to
796
| case types.KindApp: | ||
| if !resourceIsApp || !resourceAsApp.IsAWSConsole() { | ||
| return nil, trace.BadParameter("received unsupported resource type for Application kind: %T", resource) | ||
| } | ||
|
|
||
| loginGetter = role.GetAWSRoleARNs |
There was a problem hiding this comment.
this breaks resource fetching if I have non-aws apps configured:
There was a problem hiding this comment.
Added a test for this case.
This PR uses the accessChecker to remove AWS Roles which users don't have access to. Previously all the AWS Roles that the user had access to would be listed. After this change, only the AWS Roles available in the AppServer will be displayed.
marcoandredinis
force-pushed
the
marco/awsappaccess_trim_awsrole_list
branch
from
7287f3a
to
a56772a
Compare
Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com>
ryanclark
approved these changes
May 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
May 17, 2024
* Remove denied AWS Roles in AWS Role Web picker This PR uses the accessChecker to remove AWS Roles which users don't have access to. Previously all the AWS Roles that the user had access to would be listed. After this change, only the AWS Roles available in the AppServer will be displayed. * fix error for non-aws apps * Update lib/services/access_checker.go Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com> --------- Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com>
This was referenced May 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
* Remove denied AWS Roles in AWS Role Web picker This PR uses the accessChecker to remove AWS Roles which users don't have access to. Previously all the AWS Roles that the user had access to would be listed. After this change, only the AWS Roles available in the AppServer will be displayed. * fix error for non-aws apps * Update lib/services/access_checker.go --------- Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com>
justinas
pushed a commit
that referenced
this pull request
May 20, 2024
* Remove denied AWS Roles in AWS Role Web picker This PR uses the accessChecker to remove AWS Roles which users don't have access to. Previously all the AWS Roles that the user had access to would be listed. After this change, only the AWS Roles available in the AppServer will be displayed. * fix error for non-aws apps * Update lib/services/access_checker.go Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com> --------- Co-authored-by: Gavin Frazar <gavin.frazar@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the accessChecker to remove AWS Roles which users don't have access to.
Previously, all the AWS Roles that the user had access to would be listed.
After this change, only the AWS Roles actually available to the user will be displayed.
changelog: Remove invalid AWS Roles from Web UI picker
See #41499 for more details
Fixes: #41499