Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Slides removed .punch-viewer-svgpage #4

Open
sbehrends opened this issue Sep 10, 2020 · 2 comments
Open

Google Slides removed .punch-viewer-svgpage #4

sbehrends opened this issue Sep 10, 2020 · 2 comments

Comments

@sbehrends
Copy link

I just installed the extension and it is not working.
Looking into Google Slides HTML, the scanListener is not finding any term that matches .punch-viewer-svgpage a.

Probably a change on Google Slides broke the extension.

@sbehrends
Copy link
Author

Some learnings from my debugging.

  1. Looks like only works on presentation mode, I was expecting to work on design as well
  2. .punch-viewer-svgpage is shown as hidden, so iframes are not shown.

https://github.com/iblancasa/google-slides-asciinema/blob/master/chrome_extension/index.js#L55
Replacing such class with .punch-viewer-page-wrapper make it work.

@iblancasa
Copy link
Owner

Thanks! I'll apply check and apply the changes as soon as possible 👍

Looks like only works on presentation mode, I was expecting to work on design as well
Sadly no :( I was not able to find a way to make it work on design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants