Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models in the 0.2 directory should use the proper spec? #104

Open
Alos opened this issue Mar 13, 2023 · 4 comments · May be fixed by #106
Open

Models in the 0.2 directory should use the proper spec? #104

Alos opened this issue Mar 13, 2023 · 4 comments · May be fixed by #106

Comments

@Alos
Copy link
Collaborator

Alos commented Mar 13, 2023 •
edited

@adityasaky Hey I just noticed that the files in 0.2 directory reference to the 0.1 spec in comments and most importantly in the pedicateType. Should these refer to the 0.2 version?
@adityasaky
Copy link
Member

Yep! Good eye, we should fix that ASAP.

@adityasaky
Copy link
Member

@lakshya8066

@lakshya8066
Copy link
Contributor

On it @adityasaky

@lakshya8066 lakshya8066 linked a pull request Mar 16, 2023 that will close this issue
Open
@lakshya8066
Copy link
Contributor

There might be more such cases. I will analyzing the files and update the PR.
Also looking at why the tests are failing for me locally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed provenance version lakshya8066/in-toto-java
3 participants
@Alos @adityasaky @lakshya8066