Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore macOS builds to use ARM-based macos-latest #2813

Open
lidel opened this issue May 16, 2024 · 0 comments · May be fixed by #1856
Open

Restore macOS builds to use ARM-based macos-latest #2813

lidel opened this issue May 16, 2024 · 0 comments · May be fixed by #1856
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up topic/macos MacOS specific

Comments

@lidel
Copy link
Member

lidel commented May 16, 2024

This is the actual fix that needs to happen after workaround from #2811 was merged.

The way we build for macOS right now is to do Intel build, and leverage intel emulation on ARM.
This works, we have single build that works on both ARM and Intel, because intel Kubo binary is also used.

Unfortunately it is not future-proof, as ARM is the bew default.

Regressions like #2809 will happen.
Right now we are not able to build on macos-latest (14) because it is ARM-based, and there is no Intel version anymore.

Next steps

We need to rework the way our macOS build works.

There is some prior work and research done in #1856 and in #2681.

Initial thoughts:

  • Prioritize ease of maintenance.
  • Producing universal DMG sounds like a way to go, as long we have extra code that ensures correct Kubo binary is used
    • This could be done at runtime, or we could fetch both binaries (intel and arm) at build time, and manually merge them into a universal one. This will work, because the new kubo binary will be notarized as part of DMG.
@lidel lidel added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/days Estimated to take multiple days, but less than a week topic/macos MacOS specific labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up topic/macos MacOS specific
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant