istioctl: avoid parsing strings to ints or floats for string fields #51031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses reflection to check field types of our values. The performance hit should be negligible as this only runs as part of istioctl. The function turned out to be a bit more complex because we a) use a map for values instead of the struct in our IstioOperator CRD and b) protoc-gen-go does not generate proper json tags. Fixes istio#50990
istio-testing
added
the
size/L
|
@dgn: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing for now, I'll rework this a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
This uses reflection to check field types of our values. The performance hit should be negligible as this only runs as part of istioctl. The function turned out to be a bit more complex because we a) use a map for values instead of the struct in our IstioOperator CRD and b) protoc-gen-go does not generate proper json tags.
Fixes #50990