Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open File" should be a possible choice in the subtitle track drop-downs in the subtitle track selector #380

Open
killergerbah opened this issue Mar 1, 2024 · 1 comment · May be fixed by #434
Labels
enhancement New feature or request

Comments

@killergerbah
Copy link
Owner

This would make it possible to use different files as different subtitle tracks. The only way to do this right now is to drag-and-drop multiple files. When using the track selector dialog, it is only possible to load one file.

@xpire
Copy link

xpire commented Jun 10, 2024

I'm thinking about the implementation for this, if we did allow uploading subtitles in the track dropdowns, would we still allow multi-file uploads? if so, we would need to maintain multiple functions to handle either case.

Also it seems like subtitle uploads need to be passed to the BE so the file can be parsed, I'm wondering if this could be a chance to refactor how files are parsed, maybe uploading files could be changed to not immediately close the Dialogue, and instead keep it open so users can select which subtitle (the built-in ones from the video, and the ones you just uploaded) should be the first, second, etc. Then onConfirm could be changed to handle already parsed subtitles and file-uploaded subtitles.

@xpire xpire linked a pull request Jun 11, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants