Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding language profile #424

Open
cristian428 opened this issue May 14, 2024 · 2 comments
Open

Adding language profile #424

cristian428 opened this issue May 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@cristian428
Copy link

cristian428 commented May 14, 2024

I use yomitan and your extension to learn Japanese and Chinese. Most times I forget my asbplayer extension Anki settings are setup for one of the 2 languages I study. I find that to switch I need to press at least 2 buttons to get it setup right (selecting deck and then note type). I think having a kind of setting profile would be nice to easily switch between 2 or more language study goals or even just card type goals(different Anki fields etc).

Since yomitan now supports multiple languages and has a setting for it like here
Screenshot_20240515_004559_Kiwi Browser
Screenshot_20240515_004612_Kiwi Browser

Do you think it'd be possible to have the extension find what language is chosen on a given profile (since profile names can vary) and therefore automatically switch to an asbplayer profile name, that matches the language being studied ?!

That way for yomitan users, we just have to be on the desired yomitan profile and the player could have the language anki settings too.

EDIT: Or rather simply just change profile based on the subtitles language!

I just thought of this idea but don't know anything about the difficulty of implementing this so I apologize if the idea is crazy. At the very least I think profiles in asbplayer Anki section or ones that affect the whole of asbplayer settings would be beneficial to many.

Really appreciate this extension and all the work put into it. This is one of my favorites. Thank you !

@killergerbah
Copy link
Owner

No plans to do any specific integrations with Yomitan but a way to quickly change anki settings can be considered as part of the anki settings revamp for 1.3.0

@killergerbah killergerbah added this to the Extension v1.3.0 milestone May 15, 2024
@killergerbah killergerbah added the enhancement New feature or request label May 15, 2024
@cristian428
Copy link
Author

If you do decide to add a sort of profile feature I'd like to suggest subtitle settings or at the very least font settings be included in that feature because if one is switching profiles for the sake of another language, especially for languages that use kanji/hanzi glyphs, the font used could be important. Chinese has simplified and traditional character scripts and I use different fonts for Chinese and Japanese for example. It's just a thought I had because I have to switch the font every time too. Thank you for considering it, really appreciate your app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants