Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add IWYU private/export pragmas to Kokkos headers #6933

Open
tmranse opened this issue Apr 11, 2024 · 1 comment
Open

Feature request: Add IWYU private/export pragmas to Kokkos headers #6933

tmranse opened this issue Apr 11, 2024 · 1 comment
Labels
Feature Request Create new capability; will potentially require voting

Comments

@tmranse
Copy link

tmranse commented Apr 11, 2024

Kokkos recently added static asserts to ensure users were not including private header files. This can be a problem when using a tool like clangd, which attempts to "help" by automatically managing includes for you as you use objects. Would it be possible to include the appropriate IWYU pragmas so clangd knows to include e.g. Kokkos_Code.hpp instead of Kokkos_View.hpp. Presumably this could be some sort of find+sed since the private/public headers are already distinguished with the KOKKOS_IMPL_PUBLIC_INCLUDE macro?

@dalg24 dalg24 added the Feature Request Create new capability; will potentially require voting label Apr 11, 2024
@dalg24
Copy link
Member

dalg24 commented Apr 11, 2024

It is something we would be generally interested in doing.
Would you be willing to draft initial support for it plus basic testing? We can see that all headers are properly annotated after this is in place and help wrapping up the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Create new capability; will potentially require voting
Projects
None yet
Development

No branches or pull requests

2 participants