-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 slack webhook #865
Comments
I'm not AGAINST trying to find a way to make this work, if someone wants to contribute tests and an implementation. |
I got curl working in quite an annoying and fragile way. but it works. files taken from stock debian bullseye
will play with this a bit more tomorrow |
Alternatively:
If we want to include curl, I'd like an e2e test showing it works for some simple things (and doesn't drag in other deps, like git does :) Here's a starting point: diff --git a/Dockerfile.in b/Dockerfile.in
index dadb69e..18fb5a3 100644
--- a/Dockerfile.in
+++ b/Dockerfile.in
@@ -60,6 +60,7 @@ RUN /stage_binaries.sh -o {ARG_STAGING} \
-p git \
-p openssh-client \
-p ca-certificates \
+ -p curl \
-p socat \
-b /bin/grep \
-b /bin/sed \ |
Have exactly the same problems with sending notifications with webhook to slack. The way I managed to install curl into the image is with this
curl command works, but have not tested it much yet. If I encounter problems, I can let you know |
If someone can help craft an e2e that mimicks a slack integration, I could merge curl. I just want to make sure I don't add curl only to find it is missing some other helper package(s). |
hoping to send webhook to slack on sync, 400 error using built in webhook function per #508
no apt in v4 so can't install curl in a custom image to do a custom script
am I missing something?
The text was updated successfully, but these errors were encountered: