Nginx Ingress: Helm chart not able to find the opentracing variable declared

[akshaysgithub]

What happened:
Nginx ingress helm chart installation failed after trying to upgrade to latest version

Error: exit status 1
2024/05/02 08:50:04 [emerg] 28#28: unknown "opentracing_context_x_datadog_trace_id" variable
nginx: [emerg] unknown "opentracing_context_x_datadog_trace_id" variable
nginx: configuration file /tmp/nginx/nginx-cfg1324908602 test failed

-------------------------------------------------------------------------------
E0502 08:50:05.819399       8 queue.go:131] "requeuing" err=<
	
	-------------------------------------------------------------------------------
	Error: exit status 1
	2024/05/02 08:50:04 [emerg] 28#28: unknown "opentracing_context_x_datadog_trace_id" variable
	nginx: [emerg] unknown "opentracing_context_x_datadog_trace_id" variable
	nginx: configuration file /tmp/nginx/nginx-cfg1324908602 test failed

From kubectl get events --watch, I can see that readyness probe fails

60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-jl4tf    (combined from similar events): Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-jl4tf    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-jl4tf    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-jl4tf    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-jl4tf    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-jl4tf    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-jl4tf    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-rh9v2    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-rh9v2    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-rh9v2    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-rh9v2    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-rh9v2    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-rh9v2    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-rh9v2    Error reloading NGINX: ...
60m         Warning   RELOAD                 pod/ingress-nginx-controller-7cc74ccf5f-rh9v2    Error reloading NGINX: ...

What you expected to happen:

I have reverted, so running old version, updated version where it's failing

apiVersion: v2
appVersion: "1.10.1"
description: real nginx ingress chart
name: ingress-nginx
version: 4.10.1
dependencies:
  - name: ingress-nginx
    version: 4.10.1
    repository: https://kubernetes.github.io/ingress-nginx

-->

Kubernetes version (use kubectl version):
1.26.7

Environment:

• Cloud provider or hardware configuration: GCP

Configuration:
I have added it properly in our values.yaml and it's working fine for the old version, with the upgrade, I keep getting this failure message.
values.yaml:

ingress-nginx:
   config:
      enable-opentracing: "true"
      log-format-upstream: '{"remote_addr": "$remote_addr", "host": "$host", "time": "$time_iso8601", "request_id": "$req_id", "request_method": "$request_method", "request_uri": "$request_uri", "protocol": "$server_protocol", "status": $status, "bytes_sent": $body_bytes_sent, "referer": "$http_referer", "user_agent": "$http_user_agent", "request_time": $request_time, "request_length": $request_length, "upstream_name": "$proxy_upstream_name", "upstream_addr": "$upstream_addr", "upstream_response_length": "$upstream_response_length", "upstream_response_time": "$upstream_response_time", "upstream_status": "$upstream_status", "trace_id": "$opentracing_context_x_datadog_trace_id"}'

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

/remove-kind bug
/kind support

Opentracing support is deprecated in favour of OpenTelemetry
https://github.com/kubernetes/ingress-nginx/issues?q=is%3Aissue+is%3Aopen+datadog