Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Chart to create extra manifest #11351

Closed
pierluigilenoci opened this issue May 8, 2024 · 4 comments
Closed

Allow the Chart to create extra manifest #11351

pierluigilenoci opened this issue May 8, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@pierluigilenoci
Copy link

pierluigilenoci commented May 8, 2024

Sometimes, accessories to the installation may be manifests to be installed (for example, NetworkPolicies or Ingresses).

It would be nice to be able to do this directly via the Chart using the approach that Grafana, Prometheus or OAuth2 Proxy also uses.

Ref: helm/helm#12653

@pierluigilenoci pierluigilenoci added the kind/feature Categorizes issue or PR as related to a new feature. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented May 23, 2024

I cannot recall where, but we already had requests like that in the past and decided not to support them as they bring extra complexity to the chart which should be covered by user's tooling. Anything could be put into that value and users will come up with issues and asking for our support just because we are offering this possibility. It's basically adding a wildcard to add any kind of manifest, even those we do not know yet, and users will ask us to extend that feature to a point where we cannot support it anymore. It's already complicated enough to support manifests not directly related to how Ingress NGINX works right now.

I'm closing both this issue and the PR now.

/close

@k8s-ci-robot
Copy link
Contributor

@Gacko: Closing this issue.

In response to this:

I cannot recall where, but we already had requests like that in the past and decided not to support them as they bring extra complexity to the chart which should be covered by user's tooling. Anything could be put into that value and users will come up with issues and asking for our support just because we are offering this possibility. It's basically adding a wildcard to add any kind of manifest, even those we do not know yet, and users will ask us to extend that feature to a point where we cannot support it anymore. It's already complicated enough to support manifests not directly related to how Ingress NGINX works right now.

I'm closing both this issue and the PR now.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented May 23, 2024

Ah, yeah, here we go. This is the other PR: #10945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants