Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for passing user defined annotations to the IngressClass resource template #11359

Closed
cparadal opened this issue May 14, 2024 · 1 comment · Fixed by #11362
Closed

Allow for passing user defined annotations to the IngressClass resource template #11359

cparadal opened this issue May 14, 2024 · 1 comment · Fixed by #11362
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@cparadal
Copy link
Contributor

At the moment, it's not possible to pass user-defined/custom annotations to the IngressClass resource template. As can be seen here, the current template will only add an annotations stanza if the ingressClass is marked as default.

Our use case for the above is to be able to add ArgoCD related annotations, e.g. argocd.argoproj.io/sync-options: Prune=false to prevent resource pruning.

@cparadal cparadal added the kind/feature Categorizes issue or PR as related to a new feature. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants