Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for container-name autocompletion for exec commands #1600

Open
TessaIO opened this issue May 14, 2024 · 4 comments · May be fixed by kubernetes/kubernetes#124916
Open

Improve tests for container-name autocompletion for exec commands #1600

TessaIO opened this issue May 14, 2024 · 4 comments · May be fixed by kubernetes/kubernetes#124916
Assignees
@TessaIO
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@TessaIO
Copy link
Contributor

TessaIO commented May 14, 2024

What would you like to be added?

Tests in container-name autocompletion are done in separate functions and they don't cover the actual functionality which is auto-completing the container-name.
We can compact those methods in a test table and add more tests to cover more cases.

Why is this needed?

This is needed to improve the confidence in these tests and make them more maintainable and clean.
@TessaIO TessaIO added the kind/feature Categorizes issue or PR as related to a new feature. label May 14, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TessaIO
Copy link
Contributor Author

TessaIO commented May 14, 2024 •
edited

/assign

@TessaIO
Copy link
Contributor Author

TessaIO commented May 14, 2024

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 14, 2024
@TessaIO
Copy link
Contributor Author

TessaIO commented May 15, 2024

/transfer kubectl

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/kubernetes May 15, 2024
@TessaIO TessaIO linked a pull request May 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TessaIO TessaIO

Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
SIG CLI
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: improve unit tests for container name autocompletion TessaIO/kubernetes
2 participants
@k8s-ci-robot @TessaIO