Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tryRegistry fuc should once it i fails, should try outside minikube #18754

Open
medyagh opened this issue Apr 25, 2024 · 0 comments · May be fixed by #18859
Open

tryRegistry fuc should once it i fails, should try outside minikube #18754

medyagh opened this issue Apr 25, 2024 · 0 comments · May be fixed by #18859
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Apr 25, 2024

What Happened?

we have a func called tryRegistry

func tryRegistry(r command.Runner, driverName, imageRepository, ip string) {
...

...
	if rr, err := r.RunCmd(exec.Command("curl", opts...)); err != nil {
		out.WarningT("This {{.type}} is having trouble accessing https://{{.repository}}", out.V{"repository": imageRepository, "type": driver.MachineType(driverName)})
...

}

this func will warn the user if it fails to connect to the registry INSIDE minikbue, however we should do the same check outside minikube (only if the inside one fails)
that way when we debug something like this issue,
we will see in the logs that if the user's computer had any network issue or could it be related to a network module config change in minikbue ISO

#18705

Attach the log file

n/a

Operating System

None

Driver

None

@medyagh medyagh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/improvement Categorizes issue or PR as related to improving upon a current feature. labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant