Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Skew Policy - In-place Kubelet minor version upgrades are not allowed #46356

Open
avestuk opened this issue May 13, 2024 · 4 comments
Open
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@avestuk
Copy link

avestuk commented May 13, 2024

Can it really be true that doing in place upgrades of the kubelet for minor versions is not allowed? How can worker nodes be upgraded in place with this policy?

Before performing a minor version `kubelet` upgrade, [drain](/docs/tasks/administer-cluster/safely-drain-node/) pods from that node.
In-place minor version `kubelet` upgrades are not supported.

I think that the intent of the original commit is to communicate that a node must be drained before the kubelet is upgraded. I'd suggest that language like the below would be clearer.

In-place minor version `kubelet` upgrades, without node drain, are not supported
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@utkarsh-singh1
Copy link
Contributor

The fix seems perfect to me @avestuk .

@utkarsh-singh1
Copy link
Contributor

/sig docs
/language en

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/en Issues or PRs related to English language labels May 14, 2024
@mengjiao-liu
Copy link
Member

mengjiao-liu commented May 14, 2024

To me, it means almost the same thing. Maybe the understanding of In-place is different?

/cc @liggitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

No branches or pull requests

4 participants