-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
饾晱 (formerly, Twitter) icon not showing in website footer #46405
Comments
/assign |
Thank you for reporting this issue! It appears that there is already 饾晱 detail in the footer (as seen the HTML source below), but the icon isn't rendering. <li class="list-inline-item mx-2 h3" data-toggle="tooltip" data-placement="top" title=""
aria-label="X(Twitter)" data-original-title="X(Twitter)">
<a class="text-white" target="_blank" href="https://twitter.com/kubernetesio">
<i class="fab fa-x-twitter"></i>
</a>
</li> |
This looks like a bug. /retitle 饾晱 (formerly, Twitter) icon not showing in website footer |
Previously, the old Twitter logo was rendering properly (refer to the v1.28 docs website (here)). I think it's after our work involved to update to " 饾晱 " that the logo stopped rendering (refer to the commit 803bb6b where it was added). It could be that the version of Font Awesome being used by the current version of Docsy is outdated and doesn't include the new icon. The footer 饾晱 icon details are pulled from hugo.toml (refer below). Lines 252 to 255 in 44669d5
|
We should fix this issue in the footer. /priority backlog |
fontawsome 4.7.0 doesn't include this icon, the rename only happened a short time ago. |
Oh got it! Thank you for explaining and providing the links @dipesh-rawat!
I did, v4 does not include the X Twitter icon, even v5 doesn't have it, it was introduced in the latest version (v6) of fontAwesome.
I just checked the latest Docsy release, where they have bumped fontAwesome to the latest release version 6.5.2 (see #1925) Which means, updating the icon name in hugo.toml (to |
fontawsome 6.5.2 includes |
@sftim and I were discussing this very topic this week. I checked FontAwesome too and couldn't distinguish the differences. |
This is a Feature Request
What would you like to be added
The k8s.io website footer doesn't have a link to its 饾晱 account (@kubernetesio), which is now maintained by the Kubernetes community alongside CNCF. I suggest we should add that.
Why is this needed
Comments
I guess I should add it to the left group. Let me know if there's any feedback.
The text was updated successfully, but these errors were encountered: