Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

饾晱 (formerly, Twitter) icon not showing in website footer #46405

Open
ArvindParekh opened this issue May 16, 2024 · 9 comments
Open

饾晱 (formerly, Twitter) icon not showing in website footer #46405

ArvindParekh opened this issue May 16, 2024 · 9 comments
Assignees
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ArvindParekh
Copy link
Contributor

ArvindParekh commented May 16, 2024

This is a Feature Request

What would you like to be added

The k8s.io website footer doesn't have a link to its 饾晱 account (@kubernetesio), which is now maintained by the Kubernetes community alongside CNCF. I suggest we should add that.

image

Why is this needed

Comments

I guess I should add it to the left group. Let me know if there's any feedback.

@ArvindParekh ArvindParekh added the kind/feature Categorizes issue or PR as related to a new feature. label May 16, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 16, 2024
@ArvindParekh
Copy link
Contributor Author

/assign

@dipesh-rawat
Copy link
Member

Thank you for reporting this issue! It appears that there is already 饾晱 detail in the footer (as seen the HTML source below), but the icon isn't rendering.

<li class="list-inline-item mx-2 h3" data-toggle="tooltip" data-placement="top" title="" 
aria-label="X(Twitter)" data-original-title="X(Twitter)">
       <a class="text-white" target="_blank" href="https://twitter.com/kubernetesio">
            <i class="fab fa-x-twitter"></i>
        </a>
</li>

@dipesh-rawat
Copy link
Member

This looks like a bug.
/remove-kind feature

/retitle 饾晱 (formerly, Twitter) icon not showing in website footer
/kind bug
/area web-development

@k8s-ci-robot k8s-ci-robot changed the title Add 饾晱 to the Kubernetes Website Footer 饾晱 (formerly, Twitter) icon not showing in website footer May 17, 2024
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes and removed kind/feature Categorizes issue or PR as related to a new feature. labels May 17, 2024
@dipesh-rawat
Copy link
Member

Previously, the old Twitter logo was rendering properly (refer to the v1.28 docs website (here)).

I think it's after our work involved to update to " 饾晱 " that the logo stopped rendering (refer to the commit 803bb6b where it was added). It could be that the version of Font Awesome being used by the current version of Docsy is outdated and doesn't include the new icon.

The footer 饾晱 icon details are pulled from hugo.toml (refer below).

website/hugo.toml

Lines 252 to 255 in 44669d5

name = "X(Twitter)"
url = "https://twitter.com/kubernetesio"
icon = "fab fa-x-twitter"
desc = "Follow us on X (formerly Twitter) to get the latest news!"

@dipesh-rawat
Copy link
Member

We should fix this issue in the footer.

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@tengqm
Copy link
Contributor

tengqm commented May 17, 2024

fontawsome 4.7.0 doesn't include this icon, the rename only happened a short time ago.
Try search "x-twitter" on https://fontawesome.com/v4/icons/.

@ArvindParekh
Copy link
Contributor Author

Oh got it! Thank you for explaining and providing the links @dipesh-rawat!

Try search "x-twitter" on https://fontawesome.com/v4/icons/.

I did, v4 does not include the X Twitter icon, even v5 doesn't have it, it was introduced in the latest version (v6) of fontAwesome.

It could be that the version of Font Awesome being used by the current version of Docsy is outdated and doesn't include the new icon.

I just checked the latest Docsy release, where they have bumped fontAwesome to the latest release version 6.5.2 (see #1925)

Which means, updating the icon name in hugo.toml (to fa-brands fa-x-twitter, which are the classnames for x-twitter in the latest release) should fix this issue, right?

@Shubham82
Copy link
Contributor

fontawsome 6.5.2 includes x-twitter icon,
https://fontawesome.com/v6/search?q=twitter&o=r

@chris-short
Copy link
Contributor

@sftim and I were discussing this very topic this week. I checked FontAwesome too and couldn't distinguish the differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants