Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroring out when requesting fused (br)gemm with bias addition and we do not have binary col bcast flag set #766

Open
egeor opened this issue May 17, 2023 · 0 comments
Open

Erroring out when requesting fused (br)gemm with bias addition and we do not have binary col bcast flag set #766

egeor opened this issue May 17, 2023 · 0 comments
Assignees
@egeor

Comments

@egeor
Copy link
Collaborator

egeor commented May 17, 2023

No description provided.

@egeor egeor self-assigned this May 17, 2023
@adam-smnk adam-smnk mentioned this issue Jun 9, 2023
Merged
adam-smnk added a commit to plaidml/tpp-mlir that referenced this issue Jun 14, 2023
@adam-smnk
Handle 'tpp.fused_brgemm' without broadcasting (#582)
cc8ce44 
Adds a workaround to enable working lowering of `tpp.fused_brgemm`
without XSMM `bcast_col_in0` binary flag.
Additionally, quarternary ops testing is improved.

Due to current limitation of LIBXSMM
libxsmm/libxsmm#766, code generation fails
when the specific binary flag is not present.
After TPP on tensors support was introduced, `tpp.fused_brgemm` ops
which violate this limitation started showing up. To address the issue,
offending fused ops are split into separate XSMM operations which do not
have this limitations.

Work towards #580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egeor egeor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egeor