Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-1 Video Ratio Chops Off Hair/Body #191

Open
amark opened this issue May 30, 2020 · 1 comment
Open

1-1 Video Ratio Chops Off Hair/Body #191

amark opened this issue May 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@amark
Copy link

amark commented May 30, 2020

To Reproduce
Steps to reproduce the behavior:

  1. Open 2 tabs and join a call with yourself.
  2. Maximize 1 of the windows.
  3. See height not match width, chopping off hair/body.

Screenshots
Screen Shot 2020-05-29 at 7 07 37 PM

Expected behavior
Probably expect it more like this (I just deleted object-fit cover, tho that will probably cause bacon strips to not display right).
Screen Shot 2020-05-29 at 7 09 25 PM

Desktop (please complete the following information):

  • OS: Mac
  • Browser Brave latest
  • Version
@amark amark added the bug Something isn't working label May 30, 2020
@lmangani
Copy link
Collaborator

lmangani commented May 31, 2020

True - a few patches went in to maximize the view when 1:1 and will be merged this weekend, but as you can see the self-view is "honest" about what part of your view is actually guaranteed to be displayed.

This said, the bacon strips design which uses face centering to always display the user regardless of the available estate so it should swap this issue for a feature.

Let's keep this open until we can revalidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants