Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility with kubernetes by updating actix-web #4625

Closed
Kerollmops opened this issue May 7, 2024 · 1 comment · Fixed by #4675
Closed

Improve compatibility with kubernetes by updating actix-web #4625

Kerollmops opened this issue May 7, 2024 · 1 comment · Fixed by #4675
Labels
bug Something isn't working as expected
Milestone
v1.9.0

Comments

@Kerollmops
Copy link
Member

We noticed that actix-web is potentially not using the right number of CPUs (internal link) on small machines. Bumping to the latest version of actix-web leverage the use of the available_parallelism standard function and could fix the bug.
@Kerollmops Kerollmops added the bug Something isn't working as expected label May 7, 2024
@Kerollmops Kerollmops added this to the v1.9.0 milestone May 7, 2024
@dureuill dureuill mentioned this issue Jun 4, 2024
Merged
@curquiza curquiza linked a pull request Jun 4, 2024 that will close this issue
Update actix-web 4.5.1 -> 4.6.0 #4675
Merged
meili-bors bot added a commit that referenced this issue Jun 5, 2024
@meili-bors @dureuill
Merge #4675
98e062a 
4675: Update actix-web 4.5.1 -> 4.6.0 r=dureuill a=dureuill

# Pull Request

- actix-web 4.5.1 -> 4.6.0
- actix-http 3.6.0 -> 3.7.0
- actix-web-static-files (commit 2d3b6160) -> 4.0.1
- tracing-actix-web 0.7.9 -> 0.7.10
- brotli 3.4.0 -> 6.0.0

## Related issue
Fixes #4625 


Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@curquiza
Copy link
Member

curquiza commented Jun 5, 2024

Closed by #4675, will be released in rc1

@curquiza curquiza closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

Update actix-web 4.5.1 -> 4.6.0 meilisearch/meilisearch
2 participants
@Kerollmops @curquiza