Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device tests of Example 14 (DG diffusion) #4308

Closed
v-dobrev opened this issue May 16, 2024 · 3 comments · Fixed by #4311
Closed

Add device tests of Example 14 (DG diffusion) #4308

v-dobrev opened this issue May 16, 2024 · 3 comments · Fixed by #4311
Assignees
@tzanio @pazner
Labels
examples & miniapps GPU testing todo the mfem team will address this in the near future

Comments

@v-dobrev
Copy link
Member

v-dobrev commented May 16, 2024 •
edited

Since #3904 enabled device support in Example 14, we can now add it as one of the device-enabled tests in the build system, so it can be tested when building with CUDA/HIP and running make test or ctest.
@v-dobrev v-dobrev added examples & miniapps testing GPU todo the mfem team will address this in the near future labels May 16, 2024
@pazner pazner mentioned this issue May 16, 2024
Merged
61 tasks
@pazner
Copy link
Member

pazner commented May 16, 2024

Good idea. Did I make the correct changes/additions in #4311?

@v-dobrev
Copy link
Member Author

Good idea. Did I make the correct changes/additions in #4311?

Thanks @pazner! I left a suggestion in the PR discussion.

@tzanio
Copy link
Member

tzanio commented May 17, 2024

Discussion continued in #4311

@tzanio tzanio closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzanio tzanio

@pazner pazner

Labels
examples & miniapps GPU testing todo the mfem team will address this in the near future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add device tests for ex14 and ex14p mfem/mfem
3 participants
@tzanio @pazner @v-dobrev