Python: Don't send default prompt exec settings to the model #6293

moonbox3 · 2024-05-16T13:50:49Z

We are currently sending default request params to the model, and this isn't necessary. Only send non-default values.

This PR:

leverages Pydantic's exclude_defaults=True flag to not send default values as part of the payload to the model.
Updates Azure Chat Prompt Execution settings to handle the type field differently now that we aren't including all default values in the payload.
Updates the default temp value from 0.0 to 1.0 which is what OpenAI lists as their default.
Fixes Python: Execution settings should not specify defaults for settings that the AI Service has a default for. #6225

The code builds clean without any errors or warnings
The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄

markwallace-microsoft · 2024-05-16T13:53:32Z

Python 3.10 Test Coverage Report •

File	Stmts	Miss	Cover	Missing
semantic_kernel/connectors/ai/open_ai/prompt_execution_settings
azure_chat_prompt_execution_settings.py	63	1	98%	96
TOTAL	6122	1055	83%

Python 3.10 Unit Test Overview

Tests	Skipped	Failures	Errors	Time
1310	1 💤	0 ❌	0 🔥	15.936s ⏱️

moonbox3 · 2024-05-17T13:44:57Z

Going to handle this change in a different PR. Closing.

moonbox3 added 4 commits May 14, 2024 12:21

Exclude default prompt execution settings. Update unit tests.

d0dd4bc

Update to type for azure chat settings.

e5c5960

Merge main to branch.

94a1ac4

Test fixes

964b7a3

moonbox3 requested a review from a team as a code owner May 16, 2024 13:50

markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 16, 2024

moonbox3 closed this May 17, 2024