Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: OpenAIPromptExecutionSettings does not support enabling logprobs #6277

Closed
abhiksingla opened this issue May 15, 2024 · 1 comment · Fixed by #6300
Closed

.Net: OpenAIPromptExecutionSettings does not support enabling logprobs #6277

abhiksingla opened this issue May 15, 2024 · 1 comment · Fixed by #6300
Assignees
@dmytrostruk
Labels
.NET Issue or Pull requests regarding .NET code

Comments

@abhiksingla
Copy link

Currently, OpenAIPromptExecutionSettings does not support enabling logprobs in the request. It would be great, if the functionality could be enabled and logprobs be returned in the repsonse.
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels May 15, 2024
@github-actions github-actions bot changed the title .NET: OpenAIPromptExecutionSettings does not support enabling logprobs .Net: OpenAIPromptExecutionSettings does not support enabling logprobs May 15, 2024
@bartczernicki
Copy link

Agreed. Semantic Kernel already returns this in the Metadata object in responses. Would be nice to enable log probs and turn on how how many log probs to return (already part of the Azure OpenAI .NET NuGet library)

@dmytrostruk dmytrostruk mentioned this issue May 16, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue May 20, 2024
@dmytrostruk
.Net: Added logprobs property to OpenAIPromptExecutionSettings (#6300)
5e0b757 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Fixes: #6277


https://platform.openai.com/docs/api-reference/chat/create#chat-create-logprobs

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmytrostruk dmytrostruk

Labels
.NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Added logprobs property to OpenAIPromptExecutionSettings dmytrostruk/semantic-kernel
4 participants
@dmytrostruk @abhiksingla @bartczernicki @markwallace-microsoft