Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential bug in cast.py #104

Open
Alfusainey opened this issue Jul 7, 2023 · 0 comments
Open

potential bug in cast.py #104

Alfusainey opened this issue Jul 7, 2023 · 0 comments

Comments

@Alfusainey
Copy link

Alfusainey commented Jul 7, 2023

There maybe a potential bug in LayoutCast/cast.py and IDEAPlugin/res/cast.py due to the usage of path.strip('"').

The code in the which() function is similar to the code in version 6 of this Stack Overflow answer and in version 7 of the answer (5 years later), the call to path.strip('"') was removed for the reason that "'neither WIndows nor POSIX appear to encourage quoted PATH items"

Can someone kindly verify if this may cause an issue for this project?

Additional Context

We came across this issue while investigating open-source projects to see if they contain code that is similar to (or reused from) Stack Overflow and whether the code on Stack Overflow underwent any bug or security fixes. We found that the code in the which() method is somewhat similar to the one in this answer version. The issue was subsequently fixed 5 years later in version 7, however, the fix is not reflected in this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant