Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove husky for now #5127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: remove husky for now #5127

wants to merge 1 commit into from

Conversation

voxpelli
Copy link
Member

PR Checklist

Overview

@voxpelli voxpelli requested a review from a team March 26, 2024 17:31
@coveralls
Copy link

Coverage Status

coverage: 94.359%. remained the same
when pulling a23bcea on voxpelli/issue5124
into 7ac67f3 on master.

Uzlopak
Uzlopak approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@Uzlopak Uzlopak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We have a CI. We dont need husky.

@voxpelli
Copy link
Member Author

@JoshuaKGoldberg Did you have any thoughts on this? I'm quite sure you did

@JoshuaKGoldberg
Copy link
Member

I did have thoughts 😄 and they are not in favor 😄 😄 let's discuss in the issue?

@voxpelli
Copy link
Member Author

Right, I'm not used to having split split discussions between issue and PR for small changes like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠 Repo: Remove husky for now
4 participants
@voxpelli @coveralls @JoshuaKGoldberg @Uzlopak