Fall back to querying libc.so.6 if ldd can’t detect libc implementation. #17657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/packaging
Needed for correct configuration on systems that hide the libc implementation info in `ldd` output, like Gentoo.
Ferroin
force-pushed
the
improve-libc-detection
branch
from
b39b1cc
to
039b594
Compare
|
CentOS 8/Rocky 8 build failures are occurring in master as well, and thus are unrelated to this PR. |
thiagoftsm
reviewed
May 16, 2024
vkalintiris
reviewed
May 16, 2024
| NO_CMAKE_INSTALL_PREFIX | ||
| NO_CMAKE_FIND_ROOT_PATH) | ||
|
|
||
| if(NOT "${LBIC_PATH}" EQUAL "LIBC_PATH-NOTFOUND") |
There was a problem hiding this comment.
s/LBIC_PATH/LIBC_PATH/
thiagoftsm
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Needed for correct configuration on systems that hide the libc implementation info in
lddoutput, like Gentoo.Test Plan
This can be easily tested on a Gentoo system by trying to build Netdata by hand with eBPF enabled.
Without this PR, the configuration step will fail due to not being able to identify the libc implementation.
With this PR, the configuration step should succeed and correctly detect the libc implementation.
Additional Information
Fixes: #17651