Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttachCppHeap and DetachCppHeap are deprecated in V8 #52999

Closed
targos opened this issue May 15, 2024 · 2 comments
Closed

AttachCppHeap and DetachCppHeap are deprecated in V8 #52999

targos opened this issue May 15, 2024 · 2 comments
Assignees
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. v8 engine Issues and PRs related to the V8 dependency.

Comments

@targos
Copy link
Member

targos commented May 15, 2024

../../src/env.cc:569:14: warning: 'AttachCppHeap' is deprecated: Set the heap on Isolate creation using CreateParams instead. [-Wdeprecated-declarations]
    isolate->AttachCppHeap(cpp_heap_.get());
             ^
../../deps/v8/include/v8-isolate.h:1047:3: note: 'AttachCppHeap' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^

../../src/env.cc:600:15: warning: 'DetachCppHeap' is deprecated: Set the heap on Isolate creation using CreateParams instead. [-Wdeprecated-declarations]
    isolate_->DetachCppHeap();
              ^
../../deps/v8/include/v8-isolate.h:1056:3: note: 'DetachCppHeap' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON(
  ^
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label May 15, 2024
@juanarbol
Copy link
Member

I can work on this one :)

@juanarbol juanarbol self-assigned this May 19, 2024
@targos
Copy link
Member Author

targos commented May 19, 2024

@juanarbol Sorry this is actually a duplicate of #52718. I forgot that I moved that issue.
#53038 is fixing it.

@targos targos closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
@targos targos added the duplicate Issues and PRs that are duplicates of other issues or PRs. label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

2 participants