Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freebsd, only "ls" shows a table. #6862

Closed
devosalain opened this issue Oct 22, 2022 · 3 comments · Fixed by #12892
Closed

Freebsd, only "ls" shows a table. #6862

devosalain opened this issue Oct 22, 2022 · 3 comments · Fixed by #12892
Labels
platform-specific platform-specific issues question the issue author asks something
Milestone

Comments

@devosalain
Copy link

Question

With the exception of "ls" all commands show no table.
"ps" does not show a table
"zfs list" does not show a table
Even "zfs list | table -n 1" does not show a table.

This does not look like a new shell but an improved "ls". Or did i missed something.

Additional context and details

No response

@devosalain devosalain added the question the issue author asks something label Oct 22, 2022
@webbedspace
Copy link
Contributor

If ps doesn't show a table, then there's a problem. zfs list is not a Nushell command.

Does sys | table -e show a table?
What about open package.json or open Cargo.toml in a repository directory?

@rgwood
Copy link
Contributor

rgwood commented Oct 22, 2022

Thanks for the bug report. Nushell’s BSD support is very much community-driven right now; none of the core developers use BSD.

We would like to support BSD well, but realistically it probably won’t happen without a motivated BSD user to get us there.

@sholderbach sholderbach added the platform-specific platform-specific issues label Oct 23, 2022
@devosalain
Copy link
Author

devosalain commented Oct 23, 2022

I see & understand.

sys | table -e

Shows a nice table.

So you must go from creating interest & then creating additional tables.
My knowdledge of shell scripting & programming in any language is rather, limited but I can perform any tests as I use FreeBSD(&Gentoo) the whole year.

devyn added a commit that referenced this issue May 22, 2024
)

# Description

I feel like it's a little sad that BSDs get to enjoy almost everything
other than the `ps` command, and there are some tests that rely on this
command, so I figured it would be fun to patch that and make it work.

The different BSDs have diverged from each other somewhat, but generally
have a similar enough API for reading process information via
`sysctl()`, with some slightly different args.

This supports FreeBSD with the `freebsd` module, and NetBSD and OpenBSD
with the `netbsd` module. OpenBSD is a fork of NetBSD and the interface
has some minor differences but many things are the same.

I had wanted to try to support DragonFlyBSD too, but their Rust version
in the latest release is only 1.72.0, which is too old for me to want to
try to compile rustc up to 1.77.2... but I will revisit this whenever
they do update it. Dragonfly is a fork of FreeBSD, so it's likely to be
more or less the same - I just don't want to enable it without testing
it.

Fixes #6862 (partially, we probably won't be adding `zfs list`)

# User-Facing Changes
`ps` added for FreeBSD, NetBSD, and OpenBSD.

# Tests + Formatting
The CI doesn't run tests for BSDs, so I'm not entirely sure if
everything was already passing before. (Frankly, it's unlikely.) But
nothing appears to be broken.

# After Submitting
- [ ] release notes?
- [ ] DragonflyBSD, whenever they do update Rust to something close
enough for me to try it
@hustcer hustcer added this to the v0.94.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-specific platform-specific issues question the issue author asks something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants